feat(DATAGO-122217): Add ssl_verify config option for A2A proxy #838
+154
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cates Add a boolean configuration option to disable SSL certificate verification for individual A2A proxied agents. This allows connecting to remote A2A agents using self-signed certificates in development/testing environments. Changes: - Add ssl_verify field to A2AProxiedAgentConfig (default: true) - Apply ssl_verify to httpx clients for agent card fetching and task invocation - Add documentation section on SSL verification with security warnings - Add example configuration in a2a_proxy_example.yaml - Add unit tests for the new configuration option Co-Authored-By: Claude <[email protected]>
Remove duplicate docstring, add missing blank line between classes, and add trailing newline to satisfy ruff linting. Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add warning log when SSL verification is disabled - Fix missing blank lines between class definitions (PEP 8) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Add a boolean configuration option (
ssl_verify) to disable SSL certificate verification for individual A2A proxied agents. This allows connecting to remote A2A agents using self-signed certificates in development/testing environments.How was this change implemented?
ssl_verifyfield toA2AProxiedAgentConfigwith default valueTruessl_verifysetting to httpx clients for both agent card fetching and task invocationssl_verify: falseusageKey Design Decisions
True(verify certificates) to maintain security by defaultHow was this change tested?
tests/unit/agent/proxies/a2a/test_config.pyIs there anything the reviewers should focus on/be aware of?